From fb494a349c9f08ae0b140c5bc7eb3e4fc61fe8d6 Mon Sep 17 00:00:00 2001
From: John Mizerek <mizerek@gmail.com>
Date: Sat, 21 Feb 2026 16:57:08 -0800
Subject: [PATCH] Fix: Don't recommend quitting to former smokers

Former smokers have already quit - they can't take further action
on smoking. Treat them as optimal for the smoking behavior.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 lib/risk_engine/calculator.dart | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/risk_engine/calculator.dart b/lib/risk_engine/calculator.dart
index 29c00c5..e50563c 100644
--- a/lib/risk_engine/calculator.dart
+++ b/lib/risk_engine/calculator.dart
@@ -104,7 +104,9 @@ BehavioralInputs _setToOptimal(BehavioralInputs inputs, String behaviorKey) {
 bool _isOptimal(BehavioralInputs inputs, String behaviorKey) {
   switch (behaviorKey) {
     case 'smoking':
-      return inputs.smoking == SmokingStatus.never;
+      // Former smokers have already quit - no further action possible
+      return inputs.smoking == SmokingStatus.never ||
+          inputs.smoking == SmokingStatus.former;
     case 'alcohol':
       return inputs.alcohol == AlcoholLevel.none ||
           inputs.alcohol == AlcoholLevel.light;