# LUNA — QA & Testing

## Known Bugs
- **KDS not showing orders** (investigating): Order 97 stuck at StatusID=0 (never submitted). Order 96 submitted but had no Task. Root cause unclear — KDS queries Orders directly (StatusID >= 1), not Tasks. So missing Task wasn't the KDS issue. Need to determine why order 97 never submitted (app-side?).
- **KDS task creation gap** (fixed by Koda, commit 07abcee): submitCash.php and submit.php now create Tasks at StatusID=1. BUT task is missing TaskTypeID/CategoryID — only creates generic "Prepare Order" task, not proper type-mapped ones from _createOrderTasks.php. Needs follow-up.
- **Sales tax issue** (clarified by Koda): 07abcee did NOT touch tax calc. Real issue was getDetail.php not including PlatformFee in total. Fixed by Koda in commit b5394ae.
- **god.payfrit.com 502** (fixed): Lucee service crashed, Raj restarted it.

## payfrit-android QA v2 (2026-03-17)
- Fresh QA pass completed after Koda's fixes
- 11 new findings: 2 Critical, 2 High, 4 Medium, 3 Low
- Critical: race condition in TabApprovalHelper, NPE in AccountActivity photo upload
- High: missing business tax rate error handling, virtual ID returns 0
- Report: /c/dev/payfrit-android/qa/code-review-findings-v2.md
- 9/11 v1 bugs confirmed fixed by Koda ✓

## Test Results
- payfrit-beacon-android: Static + API reviewed (report: /c/dev/payfrit-beacon/qa/code-review-findings.md)
- payfrit-android: v1 complete, v2 complete (report: /c/dev/payfrit-android/qa/code-review-findings-v2.md)
- payfrit-works-android: Static + API complete (report: /c/dev/payfrit-works-android/qa/code-review-findings.md)

## Pending Verification
- payfrit-android v2 critical bugs — waiting for Koda to fix
- Koda's KDS task creation fix (07abcee) — need to verify task is created properly with new cash order
- Koda's getDetail.php PlatformFee fix (b5394ae) — need to verify order detail shows correct total

## Notes From John
- KDS bug reported: ordered $1 soda from John's Beverages (cash), nothing showed in KDS
- Order 97 was StatusID=0, never submitted — asked John to retry
- Sales tax not being computed on new orders (turned out to be PlatformFee missing from getDetail.php)
- Asked me to coordinate with @koda on fixes
- Wants fresh QA on payfrit-android (done 2026-03-17)