payfrit/payfrit-beacon-ios
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: resolve false disconnect error at end of provisioning

Browse source 
succeed() was calling disconnectPeripheral() before completion(), so the
disconnect delegate fired while writesCompleted was still false — causing
the "Unexpected disconnect" error log even on successful provisions.

Swapped order: signal completion first, then disconnect. Also removed the
redundant provisioner.disconnect() in ScanView since succeed() already
handles it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Schwifty 2026-03-23 03:47:27 +00:00
parent f082eeadad
commit 4bf4435feb
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
PayfritBeacon/BeaconProvisioner.swift
View file

@ -365,8 +365,10 @@ class BeaconProvisioner: NSObject, ObservableObject {
isTerminating = true isTerminating = true
DebugLog.shared.log("BLE: Provisioning success!") DebugLog.shared.log("BLE: Provisioning success!")
state = .success state = .success
disconnectPeripheral() // Signal completion BEFORE disconnecting — the disconnect delegate fires
// synchronously and ScanView needs writesCompleted=true before it sees it
completion?(.success(macAddress: nil)) completion?(.success(macAddress: nil))
disconnectPeripheral()
cleanup() cleanup()
} }

2
PayfritBeacon/Views/ScanView.swift
View file

@ -698,7 +698,7 @@ struct ScanView: View {
try await provisioner.writeConfig(config) try await provisioner.writeConfig(config)
writesCompleted = true writesCompleted = true
provisioner.disconnect() // No explicit disconnect needed — succeed() already disconnects
try await APIClient.shared.registerBeaconHardware( try await APIClient.shared.registerBeaconHardware(
businessId: business.id, businessId: business.id,