From f60c70f32ac2e97430faec23e675b1c9d51fa1ef Mon Sep 17 00:00:00 2001
From: Schwifty <schwifty@payfrit.com>
Date: Sun, 22 Mar 2026 21:45:10 +0000
Subject: [PATCH] =?UTF-8?q?fix:=20QR=20scanner=20crash=20=E2=80=94=20missi?=
 =?UTF-8?q?ng=20NSCameraUsageDescription=20in=20Info.plist?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The app crashed immediately when tapping QR scan because the Info.plist
was missing the required NSCameraUsageDescription key. iOS kills the app
with EXC_BAD_INSTRUCTION when camera access is requested without it.

Also fixes:
- Flash toggle could SIGABRT if lockForConfiguration failed (try? + unconditional unlock)
- Camera setup now logs errors instead of silently failing

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 PayfritBeacon/Info.plist                |  2 ++
 PayfritBeacon/Views/QRScannerView.swift | 24 +++++++++++++++++++-----
 2 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/PayfritBeacon/Info.plist b/PayfritBeacon/Info.plist
index 7ea74e1..43eff72 100644
--- a/PayfritBeacon/Info.plist
+++ b/PayfritBeacon/Info.plist
@@ -22,6 +22,8 @@
 	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
+	<key>NSCameraUsageDescription</key>
+	<string>Payfrit Beacon needs camera access to scan QR codes on beacon labels for provisioning.</string>
 	<key>NSBluetoothAlwaysUsageDescription</key>
 	<string>Payfrit Beacon needs Bluetooth to detect and configure nearby beacons.</string>
 	<key>NSBluetoothPeripheralUsageDescription</key>
diff --git a/PayfritBeacon/Views/QRScannerView.swift b/PayfritBeacon/Views/QRScannerView.swift
index 4b9e830..d3a9d0f 100644
--- a/PayfritBeacon/Views/QRScannerView.swift
+++ b/PayfritBeacon/Views/QRScannerView.swift
@@ -241,17 +241,31 @@ final class CameraPreviewUIView: UIView {
     func setFlash(_ on: Bool) {
         guard let device = AVCaptureDevice.default(for: .video),
               device.hasTorch else { return }
-        try? device.lockForConfiguration()
-        device.torchMode = on ? .on : .off
-        device.unlockForConfiguration()
+        do {
+            try device.lockForConfiguration()
+            device.torchMode = on ? .on : .off
+            device.unlockForConfiguration()
+        } catch {
+            NSLog("[QRScanner] Failed to set torch: \(error.localizedDescription)")
+        }
     }
 
     private func setupCamera() {
         let session = AVCaptureSession()
         session.sessionPreset = .high
 
-        guard let device = AVCaptureDevice.default(.builtInWideAngleCamera, for: .video, position: .back),
-              let input = try? AVCaptureDeviceInput(device: device) else { return }
+        guard let device = AVCaptureDevice.default(.builtInWideAngleCamera, for: .video, position: .back) else {
+            NSLog("[QRScanner] ERROR: No back camera available")
+            return
+        }
+
+        let input: AVCaptureDeviceInput
+        do {
+            input = try AVCaptureDeviceInput(device: device)
+        } catch {
+            NSLog("[QRScanner] ERROR: Failed to create camera input: \(error.localizedDescription)")
+            return
+        }
 
         if session.canAddInput(input) {
             session.addInput(input)