From 029279658d9754286b6e42a4b4e33e0825341672 Mon Sep 17 00:00:00 2001
From: John Pinkyfloyd <johnpinkyfloyd@Johns-Air.lan>
Date: Mon, 9 Mar 2026 09:11:15 -0700
Subject: [PATCH] Keep default-checked items with Quantity=0 when deselected

For inverted display: when user deselects a default-checked item, keep it
in cart with Quantity=0 instead of deleting. Cart displays "NO X" for these.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 api/orders/setLineItem.cfm | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/api/orders/setLineItem.cfm b/api/orders/setLineItem.cfm
index 97e0b95..37948b0 100644
--- a/api/orders/setLineItem.cfm
+++ b/api/orders/setLineItem.cfm
@@ -457,16 +457,27 @@
       <cfset attachDefaultChildren(OrderID, qExisting.ID, ItemID)>
       <cfset arrayAppend(request.attachDebug, "AFTER attachDefaultChildren call")>
     <cfelse>
-      <!--- Deselecting: mark as deleted --->
-      <cfset queryTimed(
-        "
-          UPDATE OrderLineItems
-          SET IsDeleted = b'1'
-          WHERE ID = ?
-        ",
-        [ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
+      <!--- Deselecting: check if this is a default-checked item --->
+      <cfset var qItemCheck = queryTimed(
+        "SELECT IsCheckedByDefault FROM Items WHERE ID = ? LIMIT 1",
+        [ { value = ItemID, cfsqltype = "cf_sql_integer" } ],
         { datasource = "payfrit" }
       )>
+      <cfif qItemCheck.recordCount GT 0 AND val(qItemCheck.IsCheckedByDefault) EQ 1>
+        <!--- Default item: keep with Quantity=0 for "NO X" display --->
+        <cfset queryTimed(
+          "UPDATE OrderLineItems SET Quantity = 0 WHERE ID = ?",
+          [ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
+          { datasource = "payfrit" }
+        )>
+      <cfelse>
+        <!--- Normal item: mark as deleted --->
+        <cfset queryTimed(
+          "UPDATE OrderLineItems SET IsDeleted = b'1' WHERE ID = ?",
+          [ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
+          { datasource = "payfrit" }
+        )>
+      </cfif>
     </cfif>
   <cfelse>
     <!--- Insert new if selecting, otherwise no-op --->