From 503754e248e84408f5c4aed6af43e09ca7875bcd Mon Sep 17 00:00:00 2001
From: John Pinkyfloyd <johnpinkyfloyd@Johns-Air.lan>
Date: Sun, 8 Mar 2026 23:05:44 -0700
Subject: [PATCH] Keep deselected inverted defaults in cart with Quantity=0

For inverted groups, when user deselects a default item, keep it in cart
with Quantity=0 instead of deleting. This allows cart to display "NO X".

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 api/orders/setLineItem.cfm | 54 +++++++++++++++++++++++++++++++-------
 1 file changed, 45 insertions(+), 9 deletions(-)

diff --git a/api/orders/setLineItem.cfm b/api/orders/setLineItem.cfm
index 73a13f5..3422194 100644
--- a/api/orders/setLineItem.cfm
+++ b/api/orders/setLineItem.cfm
@@ -457,15 +457,51 @@
       <cfset attachDefaultChildren(OrderID, qExisting.ID, ItemID)>
       <cfset arrayAppend(request.attachDebug, "AFTER attachDefaultChildren call")>
     <cfelse>
-      <cfset queryTimed(
-        "
-          UPDATE OrderLineItems
-          SET IsDeleted = b'1'
-          WHERE ID = ?
-        ",
-        [ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
-        { datasource = "payfrit" }
-      )>
+      <!--- Deselecting: check if this is a default from an inverted group --->
+      <!--- If so, keep it with Quantity=0 for "NO X" display; otherwise delete --->
+      <cfset var isInvertedDefault = false>
+      <cfif qItem.recordCount GT 0>
+        <cfset var qParentItem = queryTimed(
+          "SELECT IsInvertedGroup FROM Items WHERE ID = ? LIMIT 1",
+          [ { value = qItem.ParentItemID, cfsqltype = "cf_sql_integer" } ],
+          { datasource = "payfrit" }
+        )>
+        <cfif qParentItem.recordCount GT 0 AND val(qParentItem.IsInvertedGroup) EQ 1>
+          <!--- Check if item was a default --->
+          <cfset var qItemDefault = queryTimed(
+            "SELECT IsCheckedByDefault FROM Items WHERE ID = ? LIMIT 1",
+            [ { value = ItemID, cfsqltype = "cf_sql_integer" } ],
+            { datasource = "payfrit" }
+          )>
+          <cfif qItemDefault.recordCount GT 0 AND val(qItemDefault.IsCheckedByDefault) EQ 1>
+            <cfset isInvertedDefault = true>
+          </cfif>
+        </cfif>
+      </cfif>
+
+      <cfif isInvertedDefault>
+        <!--- Keep in cart with Quantity=0 for "NO X" display --->
+        <cfset queryTimed(
+          "
+            UPDATE OrderLineItems
+            SET Quantity = 0, IsDeleted = b'0'
+            WHERE ID = ?
+          ",
+          [ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
+          { datasource = "payfrit" }
+        )>
+      <cfelse>
+        <!--- Normal deselect: mark as deleted --->
+        <cfset queryTimed(
+          "
+            UPDATE OrderLineItems
+            SET IsDeleted = b'1'
+            WHERE ID = ?
+          ",
+          [ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
+          { datasource = "payfrit" }
+        )>
+      </cfif>
     </cfif>
   <cfelse>
     <!--- Insert new if selecting, otherwise no-op --->