payfrit/payfrit-biz
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert inverted deselect logic - back to simple delete

Browse source
This commit is contained in:
John Pinkyfloyd 2026-03-09 07:34:39 -07:00
parent 5e01bcd989
commit 6ffc77fcaf
1 changed files with 10 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
api/orders/setLineItem.cfm
View file

@ -457,47 +457,7 @@
<cfset attachDefaultChildren(OrderID, qExisting.ID, ItemID)>
<cfset arrayAppend(request.attachDebug, "AFTER attachDefaultChildren call")>
<cfelse>
<!--- Deselecting: check if this is a default from an inverted group --->
<!--- If so, keep it with Quantity=0 for "NO X" display; otherwise delete --->
<cfset var isInvertedDefault = false>
<cftry>
<cfif qItem.recordCount GT 0 AND val(qItem.ParentItemID) GT 0>
<cfset var qParentItem = queryTimed(
"SELECT IsInvertedGroup FROM Items WHERE ID = ? LIMIT 1",
[ { value = val(qItem.ParentItemID), cfsqltype = "cf_sql_integer" } ],
{ datasource = "payfrit" }
)>
<cfif qParentItem.recordCount GT 0 AND val(qParentItem.IsInvertedGroup) EQ 1>
<!--- Check if item was a default --->
<cfset var qItemDefault = queryTimed(
"SELECT IsCheckedByDefault FROM Items WHERE ID = ? LIMIT 1",
[ { value = ItemID, cfsqltype = "cf_sql_integer" } ],
{ datasource = "payfrit" }
)>
<cfif qItemDefault.recordCount GT 0 AND val(qItemDefault.IsCheckedByDefault) EQ 1>
<cfset isInvertedDefault = true>
</cfif>
</cfif>
</cfif>
<cfcatch>
<!--- On error, default to normal delete behavior --->
<cfset isInvertedDefault = false>
</cfcatch>
</cftry>
<cfif isInvertedDefault>
<!--- Keep in cart with Quantity=0 for "NO X" display --->
<cfset queryTimed(
"
UPDATE OrderLineItems
SET Quantity = 0, IsDeleted = b'0'
WHERE ID = ?
",
[ { value = qExisting.ID, cfsqltype = "cf_sql_integer" } ],
{ datasource = "payfrit" }
)>
<cfelse>
<!--- Normal deselect: mark as deleted --->
<!--- Deselecting: mark as deleted --->
<cfset queryTimed(
"
UPDATE OrderLineItems
@ -508,7 +468,6 @@
{ datasource = "payfrit" }
)>
</cfif>
</cfif>
<cfelse>
<!--- Insert new if selecting, otherwise no-op --->
<cfif IsSelected>