From 94ee89d1f314de5700947e8946cb88b19f2c4857 Mon Sep 17 00:00:00 2001
From: John Mizerek <mizerek@gmail.com>
Date: Fri, 30 Jan 2026 23:30:10 -0800
Subject: [PATCH] Fix FK references on OrderLineItems incorrectly changed to ID
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- setLineItem.cfm: WHERE ID→WHERE OrderID on 3 OrderLineItems queries
  that filter by order (FK), not by line item PK
- setLineItem.cfm: qKids.ItemID→qKids.ID, qTemplateKids.ItemID→
  qTemplateKids.ID (query only selects ID column from Items)
- abandonOrder.cfm: DELETE FROM OrderLineItems WHERE ID→WHERE OrderID
  (was deleting one line item by PK instead of all items for the order)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 api/orders/abandonOrder.cfm |  2 +-
 api/orders/setLineItem.cfm  | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/api/orders/abandonOrder.cfm b/api/orders/abandonOrder.cfm
index 5cb57b7..29f4a78 100644
--- a/api/orders/abandonOrder.cfm
+++ b/api/orders/abandonOrder.cfm
@@ -52,7 +52,7 @@
 
   <!--- Delete line items --->
   <cfset queryExecute(
-    "DELETE FROM OrderLineItems WHERE ID = ?",
+    "DELETE FROM OrderLineItems WHERE OrderID = ?",
     [{ value = OrderID, cfsqltype = "cf_sql_integer" }],
     { datasource = "payfrit" }
   )>
diff --git a/api/orders/setLineItem.cfm b/api/orders/setLineItem.cfm
index 6c1d901..6437bf7 100644
--- a/api/orders/setLineItem.cfm
+++ b/api/orders/setLineItem.cfm
@@ -82,13 +82,13 @@
   <!--- Process direct children --->
   <cfloop query="qKids">
     <cfset arrayAppend(request.attachDebug, "  -> direct child: ItemID=#qKids.ID#")>
-    <cfset processDefaultChild(arguments.OrderID, arguments.ParentLineItemID, qKids.ItemID, qKids.Price)>
+    <cfset processDefaultChild(arguments.OrderID, arguments.ParentLineItemID, qKids.ID, qKids.Price)>
   </cfloop>
 
   <!--- Process template children --->
   <cfloop query="qTemplateKids">
     <cfset arrayAppend(request.attachDebug, "  -> template child: ItemID=#qTemplateKids.ID#")>
-    <cfset processDefaultChild(arguments.OrderID, arguments.ParentLineItemID, qTemplateKids.ItemID, qTemplateKids.Price)>
+    <cfset processDefaultChild(arguments.OrderID, arguments.ParentLineItemID, qTemplateKids.ID, qTemplateKids.Price)>
   </cfloop>
 </cffunction>
 
@@ -103,7 +103,7 @@
     "
       SELECT ID
       FROM OrderLineItems
-      WHERE ID = ?
+      WHERE OrderID = ?
         AND ParentOrderLineItemID = ?
         AND ItemID = ?
       LIMIT 1
@@ -375,7 +375,7 @@
             "
               UPDATE OrderLineItems
               SET IsDeleted = b'1'
-              WHERE ID = ?
+              WHERE OrderID = ?
                 AND ParentOrderLineItemID = ?
                 AND ItemID != ?
                 AND IsDeleted = b'0'
@@ -401,7 +401,7 @@
       "
         SELECT ID
         FROM OrderLineItems
-        WHERE ID = ?
+        WHERE OrderID = ?
           AND ParentOrderLineItemID = ?
           AND ItemID = ?
         LIMIT 1