From ea34f302acb825d41ddd7b77df584a7372fcbe8b Mon Sep 17 00:00:00 2001
From: John Mizerek <mizerek@gmail.com>
Date: Thu, 19 Feb 2026 11:31:31 -0800
Subject: [PATCH] Require TaxRate and PayfritFee to be configured - no
 fallbacks

Both values MUST be set per business. If not configured, the menu
API will return an error instead of silently using defaults.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 api/menu/items.cfm | 49 ++++++++++++++++++++++------------------------
 1 file changed, 23 insertions(+), 26 deletions(-)

diff --git a/api/menu/items.cfm b/api/menu/items.cfm
index f035544..c7610d5 100644
--- a/api/menu/items.cfm
+++ b/api/menu/items.cfm
@@ -531,33 +531,30 @@
 
   <!--- Get brand color, tax rate, payfrit fee, and header image for this business --->
   <cfset brandColor = "">
-  <cfset businessTaxRate = 0>
-  <cfset businessPayfritFee = 0.065>
   <cfset headerImageUrl = "">
-  <cftry>
-    <cfset qBrand = queryTimed(
-      "SELECT BrandColor AS BusinessBrandColor, TaxRate, PayfritFee, HeaderImageExtension FROM Businesses WHERE ID = ?",
-      [ { value = BusinessID, cfsqltype = "cf_sql_integer" } ],
-      { datasource = "payfrit" }
-    )>
-    <cfif qBrand.recordCount GT 0>
-      <cfif len(trim(qBrand.BusinessBrandColor))>
-        <cfset brandColor = left(qBrand.BusinessBrandColor, 1) EQ chr(35) ? qBrand.BusinessBrandColor : chr(35) & qBrand.BusinessBrandColor>
-      </cfif>
-      <cfif isNumeric(qBrand.TaxRate)>
-        <cfset businessTaxRate = qBrand.TaxRate>
-      </cfif>
-      <cfif isNumeric(qBrand.PayfritFee)>
-        <cfset businessPayfritFee = qBrand.PayfritFee>
-      </cfif>
-      <cfif len(trim(qBrand.HeaderImageExtension))>
-        <cfset headerImageUrl = "/uploads/headers/#BusinessID#.#qBrand.HeaderImageExtension#">
-      </cfif>
-    </cfif>
-    <cfcatch>
-      <!--- Column may not exist yet, ignore --->
-    </cfcatch>
-  </cftry>
+  <cfset qBrand = queryTimed(
+    "SELECT BrandColor AS BusinessBrandColor, TaxRate, PayfritFee, HeaderImageExtension FROM Businesses WHERE ID = ?",
+    [ { value = BusinessID, cfsqltype = "cf_sql_integer" } ],
+    { datasource = "payfrit" }
+  )>
+  <cfif qBrand.recordCount EQ 0>
+    <cfset apiAbort({ "OK": false, "ERROR": "business_not_found" })>
+  </cfif>
+  <!--- TaxRate and PayfritFee MUST be configured - no fallbacks --->
+  <cfif NOT isNumeric(qBrand.TaxRate)>
+    <cfset apiAbort({ "OK": false, "ERROR": "business_tax_rate_not_configured" })>
+  </cfif>
+  <cfif NOT isNumeric(qBrand.PayfritFee) OR qBrand.PayfritFee LTE 0>
+    <cfset apiAbort({ "OK": false, "ERROR": "business_payfrit_fee_not_configured" })>
+  </cfif>
+  <cfset businessTaxRate = qBrand.TaxRate>
+  <cfset businessPayfritFee = qBrand.PayfritFee>
+  <cfif len(trim(qBrand.BusinessBrandColor))>
+    <cfset brandColor = left(qBrand.BusinessBrandColor, 1) EQ chr(35) ? qBrand.BusinessBrandColor : chr(35) & qBrand.BusinessBrandColor>
+  </cfif>
+  <cfif len(trim(qBrand.HeaderImageExtension))>
+    <cfset headerImageUrl = "/uploads/headers/#BusinessID#.#qBrand.HeaderImageExtension#">
+  </cfif>
 
   <cfset apiAbort({
     "OK": true,