From ec6bfdd9c9d039cfaa0d7fe86afdcb1dd4451f72 Mon Sep 17 00:00:00 2001 From: John Mizerek Date: Wed, 28 Jan 2026 17:33:21 -0800 Subject: [PATCH] Fix menu save: javaCast null breaks variable access in Lucee 7 javaCast('null','') makes the variable truly undefined, causing 'variable doesn't exist' errors when referenced in query params. Use empty string + len() check instead. Co-Authored-By: Claude Opus 4.5 --- api/menu/menus.cfm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/api/menu/menus.cfm b/api/menu/menus.cfm index 9b72c00..35d1eaa 100644 --- a/api/menu/menus.cfm +++ b/api/menu/menus.cfm @@ -125,8 +125,8 @@ try { menuName = structKeyExists(requestData, "MenuName") ? trim(requestData.MenuName) : ""; menuDescription = structKeyExists(requestData, "MenuDescription") ? trim(requestData.MenuDescription) : ""; menuDaysActive = structKeyExists(requestData, "MenuDaysActive") ? val(requestData.MenuDaysActive) : 127; - menuStartTime = structKeyExists(requestData, "MenuStartTime") && len(trim(requestData.MenuStartTime)) ? trim(requestData.MenuStartTime) : javaCast("null", ""); - menuEndTime = structKeyExists(requestData, "MenuEndTime") && len(trim(requestData.MenuEndTime)) ? trim(requestData.MenuEndTime) : javaCast("null", ""); + menuStartTime = structKeyExists(requestData, "MenuStartTime") && len(trim(requestData.MenuStartTime)) ? trim(requestData.MenuStartTime) : ""; + menuEndTime = structKeyExists(requestData, "MenuEndTime") && len(trim(requestData.MenuEndTime)) ? trim(requestData.MenuEndTime) : ""; menuSortOrder = structKeyExists(requestData, "MenuSortOrder") ? val(requestData.MenuSortOrder) : 0; if (len(menuName) == 0) { @@ -150,8 +150,8 @@ try { menuName: { value: menuName, cfsqltype: "cf_sql_varchar" }, menuDescription: { value: menuDescription, cfsqltype: "cf_sql_varchar" }, menuDaysActive: { value: menuDaysActive, cfsqltype: "cf_sql_integer" }, - menuStartTime: { value: menuStartTime, cfsqltype: "cf_sql_time", null: isNull(menuStartTime) }, - menuEndTime: { value: menuEndTime, cfsqltype: "cf_sql_time", null: isNull(menuEndTime) }, + menuStartTime: { value: menuStartTime, cfsqltype: "cf_sql_time", null: !len(menuStartTime) }, + menuEndTime: { value: menuEndTime, cfsqltype: "cf_sql_time", null: !len(menuEndTime) }, menuSortOrder: { value: menuSortOrder, cfsqltype: "cf_sql_integer" } }, { datasource: "payfrit" }); @@ -173,8 +173,8 @@ try { menuName: { value: menuName, cfsqltype: "cf_sql_varchar" }, menuDescription: { value: menuDescription, cfsqltype: "cf_sql_varchar" }, menuDaysActive: { value: menuDaysActive, cfsqltype: "cf_sql_integer" }, - menuStartTime: { value: menuStartTime, cfsqltype: "cf_sql_time", null: isNull(menuStartTime) }, - menuEndTime: { value: menuEndTime, cfsqltype: "cf_sql_time", null: isNull(menuEndTime) }, + menuStartTime: { value: menuStartTime, cfsqltype: "cf_sql_time", null: !len(menuStartTime) }, + menuEndTime: { value: menuEndTime, cfsqltype: "cf_sql_time", null: !len(menuEndTime) }, menuSortOrder: { value: menuSortOrder, cfsqltype: "cf_sql_integer" } }, { datasource: "payfrit" });