From 3384f128e1ce029cfff4d9c68a221ad80a4eb1af Mon Sep 17 00:00:00 2001
From: John Mizerek <mizerek@gmail.com>
Date: Fri, 16 Jan 2026 09:55:45 -0800
Subject: [PATCH] Fix task acceptance incorrectly marking orders as delivered
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When accepting a task, the order status was being set to 4 (Delivery in progress),
which caused the order to disappear from KDS and broke auto-complete functionality.

The correct flow is:
- Order at status 3 (Ready) → Worker accepts task → Order stays at 3
- Worker completes task → Order moves to status 5 (Delivered)

Removed the order status update from accept.cfm so orders remain visible in KDS
until the delivery task is actually completed.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---
 api/debug/checkTask.cfm | 55 +++++++++++++++++++++++++++++++++++++++++
 api/tasks/accept.cfm    | 13 +++-------
 2 files changed, 58 insertions(+), 10 deletions(-)
 create mode 100644 api/debug/checkTask.cfm

diff --git a/api/debug/checkTask.cfm b/api/debug/checkTask.cfm
new file mode 100644
index 0000000..43afad8
--- /dev/null
+++ b/api/debug/checkTask.cfm
@@ -0,0 +1,55 @@
+<cfsetting showdebugoutput="false">
+<cfsetting enablecfoutputonly="true">
+
+<cffunction name="apiAbort" access="public" returntype="void" output="true">
+  <cfargument name="payload" type="struct" required="true">
+  <cfcontent type="application/json; charset=utf-8">
+  <cfoutput>#serializeJSON(arguments.payload)#</cfoutput>
+  <cfabort>
+</cffunction>
+
+<cfset TaskID = val(url.TaskID ?: 0)>
+
+<cfif TaskID LTE 0>
+  <cfset apiAbort({ "OK": false, "ERROR": "missing_params", "MESSAGE": "TaskID required in URL" })>
+</cfif>
+
+<cftry>
+  <cfset qTask = queryExecute("
+    SELECT TaskID, TaskBusinessID, TaskCategoryID, TaskOrderID, TaskTypeID,
+           TaskClaimedByUserID, TaskClaimedOn, TaskCompletedOn,
+           TaskAddedOn, TaskSourceType, TaskSourceID
+    FROM Tasks
+    WHERE TaskID = ?
+  ", [ { value = TaskID, cfsqltype = "cf_sql_integer" } ], { datasource = "payfrit" })>
+
+  <cfif qTask.recordCount EQ 0>
+    <cfset apiAbort({ "OK": false, "ERROR": "not_found", "MESSAGE": "Task not found" })>
+  </cfif>
+
+  <cfset apiAbort({
+    "OK": true,
+    "TASK": {
+      "TaskID": qTask.TaskID,
+      "TaskBusinessID": qTask.TaskBusinessID,
+      "TaskCategoryID": qTask.TaskCategoryID,
+      "TaskOrderID": qTask.TaskOrderID,
+      "TaskTypeID": qTask.TaskTypeID,
+      "TaskClaimedByUserID": qTask.TaskClaimedByUserID,
+      "TaskClaimedOn": qTask.TaskClaimedOn,
+      "TaskCompletedOn": qTask.TaskCompletedOn,
+      "TaskAddedOn": qTask.TaskAddedOn,
+      "TaskSourceType": qTask.TaskSourceType,
+      "TaskSourceID": qTask.TaskSourceID,
+      "IS_COMPLETED": NOT (isNull(qTask.TaskCompletedOn) OR len(trim(qTask.TaskCompletedOn)) EQ 0)
+    }
+  })>
+
+  <cfcatch>
+    <cfset apiAbort({
+      "OK": false,
+      "ERROR": "server_error",
+      "MESSAGE": cfcatch.message
+    })>
+  </cfcatch>
+</cftry>
diff --git a/api/tasks/accept.cfm b/api/tasks/accept.cfm
index c77c303..2cef886 100644
--- a/api/tasks/accept.cfm
+++ b/api/tasks/accept.cfm
@@ -62,16 +62,9 @@
     { value = TaskID, cfsqltype = "cf_sql_integer" }
   ], { datasource = "payfrit" })>
 
-  <!--- If task has an associated order, update order status to 4 (Claimed) --->
-  <cfif val(qTask.TaskOrderID) GT 0>
-    <cfset queryExecute("
-      UPDATE Orders
-      SET OrderStatusID = 4,
-          OrderLastEditedOn = NOW()
-      WHERE OrderID = ?
-        AND OrderStatusID = 3
-    ", [ { value = qTask.TaskOrderID, cfsqltype = "cf_sql_integer" } ], { datasource = "payfrit" })>
-  </cfif>
+  <!--- NOTE: Do NOT update order status when accepting/claiming task --->
+  <!--- Order should remain at status 3 (Order complete, final prep) until task is completed --->
+  <!--- When task is completed, order status will be updated to 5 (Delivered) --->
 
   <cfset apiAbort({
     "OK": true,