From d783f9107514490d3bbe6abc4f8bf7396a2dd9df Mon Sep 17 00:00:00 2001
From: John Mizerek <mizerek@gmail.com>
Date: Fri, 23 Jan 2026 21:40:32 -0800
Subject: [PATCH] Fix null value handling in setLineItem API

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 api/orders/setLineItem.cfm | 52 +++++++++++++++++++-------------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/api/orders/setLineItem.cfm b/api/orders/setLineItem.cfm
index 1b01000..5cb133c 100644
--- a/api/orders/setLineItem.cfm
+++ b/api/orders/setLineItem.cfm
@@ -206,22 +206,22 @@
   </cfif>
 
   <cfset out.ORDER = {
-    "OrderID": qOrder.OrderID,
-    "OrderUUID": qOrder.OrderUUID,
-    "OrderUserID": qOrder.OrderUserID,
-    "OrderBusinessID": qOrder.OrderBusinessID,
-    "OrderBusinessDeliveryMultiplier": qOrder.OrderBusinessDeliveryMultiplier,
-    "OrderTypeID": qOrder.OrderTypeID,
-    "OrderDeliveryFee": qOrder.OrderDeliveryFee,
-    "OrderStatusID": qOrder.OrderStatusID,
-    "OrderAddressID": qOrder.OrderAddressID,
-    "OrderPaymentID": qOrder.OrderPaymentID,
-    "OrderRemarks": qOrder.OrderRemarks,
+    "OrderID": val(qOrder.OrderID),
+    "OrderUUID": qOrder.OrderUUID ?: "",
+    "OrderUserID": val(qOrder.OrderUserID),
+    "OrderBusinessID": val(qOrder.OrderBusinessID),
+    "OrderBusinessDeliveryMultiplier": val(qOrder.OrderBusinessDeliveryMultiplier),
+    "OrderTypeID": val(qOrder.OrderTypeID),
+    "OrderDeliveryFee": val(qOrder.OrderDeliveryFee),
+    "OrderStatusID": val(qOrder.OrderStatusID),
+    "OrderAddressID": val(qOrder.OrderAddressID),
+    "OrderPaymentID": val(qOrder.OrderPaymentID),
+    "OrderRemarks": qOrder.OrderRemarks ?: "",
     "OrderAddedOn": qOrder.OrderAddedOn,
     "OrderLastEditedOn": qOrder.OrderLastEditedOn,
     "OrderSubmittedOn": qOrder.OrderSubmittedOn,
-    "OrderServicePointID": qOrder.OrderServicePointID,
-    "BusinessDeliveryFee": qOrder.BusinessDeliveryFee
+    "OrderServicePointID": val(qOrder.OrderServicePointID),
+    "BusinessDeliveryFee": val(qOrder.BusinessDeliveryFee)
   }>
 
   <cfset var qLI = queryExecute(
@@ -254,20 +254,20 @@
   <cfset var rows = []>
   <cfloop query="qLI">
     <cfset arrayAppend(rows, {
-      "OrderLineItemID": qLI.OrderLineItemID,
-      "OrderLineItemParentOrderLineItemID": qLI.OrderLineItemParentOrderLineItemID,
-      "OrderLineItemOrderID": qLI.OrderLineItemOrderID,
-      "OrderLineItemItemID": qLI.OrderLineItemItemID,
-      "OrderLineItemStatusID": qLI.OrderLineItemStatusID,
-      "OrderLineItemPrice": qLI.OrderLineItemPrice,
-      "OrderLineItemQuantity": qLI.OrderLineItemQuantity,
-      "OrderLineItemRemark": qLI.OrderLineItemRemark,
-      "OrderLineItemIsDeleted": qLI.OrderLineItemIsDeleted,
+      "OrderLineItemID": val(qLI.OrderLineItemID),
+      "OrderLineItemParentOrderLineItemID": val(qLI.OrderLineItemParentOrderLineItemID),
+      "OrderLineItemOrderID": val(qLI.OrderLineItemOrderID),
+      "OrderLineItemItemID": val(qLI.OrderLineItemItemID),
+      "OrderLineItemStatusID": val(qLI.OrderLineItemStatusID),
+      "OrderLineItemPrice": val(qLI.OrderLineItemPrice),
+      "OrderLineItemQuantity": val(qLI.OrderLineItemQuantity),
+      "OrderLineItemRemark": qLI.OrderLineItemRemark ?: "",
+      "OrderLineItemIsDeleted": val(qLI.OrderLineItemIsDeleted),
       "OrderLineItemAddedOn": qLI.OrderLineItemAddedOn,
-      "ItemName": qLI.ItemName,
-      "ItemParentItemID": qLI.ItemParentItemID,
-      "ItemParentName": qLI.ItemParentName,
-      "ItemIsCheckedByDefault": qLI.ItemIsCheckedByDefault
+      "ItemName": qLI.ItemName ?: "",
+      "ItemParentItemID": val(qLI.ItemParentItemID),
+      "ItemParentName": qLI.ItemParentName ?: "",
+      "ItemIsCheckedByDefault": val(qLI.ItemIsCheckedByDefault)
     })>
   </cfloop>