payfrit/payfrit-works
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix null date handling in order history API

Browse source 
Safely handle null/empty OrderAddedOn and OrderLastEditedOn fields
that were causing server errors when formatting dates.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
John Mizerek 2026-01-14 21:36:18 -08:00
parent 4c06040f41
commit f98eaa4ba1
1 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
api/orders/history.cfm
View file

@ -125,6 +125,21 @@ try {
default: statusText = "Unknown"; default: statusText = "Unknown";
} }
// Safely format dates
createdAt = "";
try {
if (!isNull(row.OrderAddedOn) && len(trim(row.OrderAddedOn))) {
createdAt = dateTimeFormat(row.OrderAddedOn, "yyyy-mm-dd'T'HH:nn:ss");
}
} catch (any de) { createdAt = ""; }
completedAt = "";
try {
if (row.OrderStatusID >= 4 && !isNull(row.OrderLastEditedOn) && len(trim(row.OrderLastEditedOn))) {
completedAt = dateTimeFormat(row.OrderLastEditedOn, "yyyy-mm-dd'T'HH:nn:ss");
}
} catch (any de) { completedAt = ""; }
arrayAppend(orders, { arrayAppend(orders, {
"OrderID": row.OrderID, "OrderID": row.OrderID,
"OrderUUID": row.OrderUUID ?: "", "OrderUUID": row.OrderUUID ?: "",
@ -134,12 +149,10 @@ try {
"OrderStatusID": row.OrderStatusID, "OrderStatusID": row.OrderStatusID,
"StatusName": statusText, "StatusName": statusText,
"OrderTypeID": row.OrderTypeID ?: 0, "OrderTypeID": row.OrderTypeID ?: 0,
"TypeName": row.OrderTypeName, "TypeName": row.OrderTypeName ?: "Unknown",
"ItemCount": itemCount, "ItemCount": itemCount,
"CreatedAt": dateTimeFormat(row.OrderAddedOn, "yyyy-mm-dd'T'HH:nn:ss"), "CreatedAt": createdAt,
"CompletedAt": (row.OrderStatusID >= 4 && len(row.OrderLastEditedOn)) "CompletedAt": completedAt
? dateTimeFormat(row.OrderLastEditedOn, "yyyy-mm-dd'T'HH:nn:ss")
: ""
}); });
} }